You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:00:06 UTC

[GitHub] [incubator-iceberg] edgarRd commented on a change in pull request #1070: Update metrics tests to use Iceberg generics

edgarRd commented on a change in pull request #1070:
URL: https://github.com/apache/incubator-iceberg/pull/1070#discussion_r430790459



##########
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##########
@@ -95,59 +88,57 @@
       optional(8, "dateCol", DateType.get()),
       required(9, "timeCol", TimeType.get()),
       required(10, "timestampCol", TimestampType.withoutZone()),
-      optional(11, "uuidCol", UUIDType.get()),
-      required(12, "fixedCol", FixedType.ofLength(4)),
-      required(13, "binaryCol", BinaryType.get())
+      required(11, "fixedCol", FixedType.ofLength(4)),

Review comment:
       Sorry if I'm missing some context, but why is the `uuidCol` dropped? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org