You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/29 02:15:23 UTC

[GitHub] [apisix] tzssangglass commented on a diff in pull request #8575: feat: support configure http listen backlog in config

tzssangglass commented on code in PR #8575:
URL: https://github.com/apache/apisix/pull/8575#discussion_r1058691169


##########
t/cli/test_main.sh:
##########
@@ -55,6 +55,33 @@ fi
 
 echo "passed: nginx.conf file contains reuseport configuration"
 
+# check default listen_backlog
+
+! grep -E "listen .* backlog=" conf/nginx.conf > /dev/null
+if [ ! $? -eq 0 ]; then
+    echo "failed: nginx.conf file contains backlog configuration"
+    exit 1
+fi
+
+echo "passed: nginx.conf file default backlog configuration"
+
+# check sets listen_backlog
+echo "
+apisix:
+  listen_backlog: 1023
+
+" > conf/config.yaml
+
+make init
+
+count_http_backlog=`grep -Ec "listen .* backlog=" conf/nginx.conf`

Review Comment:
   ```
   count_http_backlog=`grep -Ec "listen .* backlog=1023" conf/nginx.conf`
   ```
   
   is ok?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org