You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brian Fox (JIRA)" <ji...@codehaus.org> on 2009/01/07 19:11:19 UTC
[jira] Created: (MNG-3974) New mirror syntax is not supported in
3.0
New mirror syntax is not supported in 3.0
-----------------------------------------
Key: MNG-3974
URL: http://jira.codehaus.org/browse/MNG-3974
Project: Maven 2
Issue Type: Bug
Components: Artifacts and Repositories
Affects Versions: 3.0-alpha-1
Reporter: Brian Fox
Fix For: 3.0-alpha-2
The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3974) New mirror syntax is not supported in
3.0
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160448#action_160448 ]
Jason van Zyl commented on MNG-3974:
------------------------------------
Brian, can you take a look because it looks like it's there to me.
> New mirror syntax is not supported in 3.0
> -----------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.0-alpha-2
>
>
> The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3974) New mirror syntax is not stopping on
first match
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160506#action_160506 ]
Brian Fox commented on MNG-3974:
--------------------------------
This is fixed, just needs an IT
> New mirror syntax is not stopping on first match
> ------------------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.9, 2.1.0-M1, 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 2.0.10, 2.1.0-M2, 3.0-alpha-2
>
>
> The first match of a pattern should be returned, but the last one is being found.
> Exact matches should always supercede a pattern.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3974) New mirror syntax is not supported in
3.0
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-3974:
---------------------------
Assignee: Brian Fox
Fix Version/s: 3.0-alpha-2
> New mirror syntax is not supported in 3.0
> -----------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.0-alpha-2
>
>
> The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3974) New mirror syntax is not supported in
3.0
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160493#action_160493 ]
Brian Fox commented on MNG-3974:
--------------------------------
Issue confirmed with a unit test.
> New mirror syntax is not supported in 3.0
> -----------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.0-alpha-2
>
>
> The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3974) New mirror syntax is not stopping on
first match
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-3974.
----------------------------------
Resolution: Fixed
IT is up and happy.
> New mirror syntax is not stopping on first match
> ------------------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.9, 2.1.0-M1, 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Benjamin Bentmann
> Fix For: 2.0.10, 2.1.0-M2, 3.0-alpha-2
>
>
> The first match of a pattern should be returned, but the last one is being found.
> Exact matches should always supercede a pattern.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3974) New mirror syntax is not stopping on
first match
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-3974:
---------------------------
Description:
The first match of a pattern should be returned, but the last one is being found.
Exact matches should always supercede a pattern.
was:The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
Affects Version/s: 2.0.9
2.1.0-M1
Fix Version/s: 2.1.0-M2
2.0.10
Summary: New mirror syntax is not stopping on first match (was: New mirror syntax is not supported in 3.0)
> New mirror syntax is not stopping on first match
> ------------------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.9, 2.1.0-M1, 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 2.0.10, 2.1.0-M2, 3.0-alpha-2
>
>
> The first match of a pattern should be returned, but the last one is being found.
> Exact matches should always supercede a pattern.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3974) New mirror syntax is not supported in
3.0
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160483#action_160483 ]
Benjamin Bentmann commented on MNG-3974:
----------------------------------------
The code in {{DefaultWagonManager}} from trunk appears to support the extended mirror syntax. For instance, the IT for MNG-3461 checking "external:*" passes with Maven 3.x.
However, according to Brian's proposal and the comments in {{getMirror()}}, the first match should win. But the loop is not quit upon a match but continues, potentially choosing a later match. Could that be the cause for Brian's issue?
While we talk about ordering of mirrors, for a {{settings.xml}}
{code:xml}
<mirrors>
<mirror>
<id>test-a</id>
<url>...</url>
<mirrorOf>foo</mirrorOf>
</mirror>
<mirror>
<id>test-b</id>
<url>...</url>
<mirrorOf>foo</mirrorOf>
</mirror>
</mirrors>
{code}
the mirror "test-b" will be chosen, i.e. the last definition, due later mirrors with equal mirrorOf overriding the former ones. Doesn't feel very consistent with the strategy of first match wins.
> New mirror syntax is not supported in 3.0
> -----------------------------------------
>
> Key: MNG-3974
> URL: http://jira.codehaus.org/browse/MNG-3974
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.0-alpha-2
>
>
> The new mirror syntax introduced in 2.0.9 / MNG-3461 is not implemented in 3.0 yet.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira