[GitHub] [atlas] andrewluotechnologies commented on a change in pull request #61: ATLAS-3295: Remove unused setup code and documentation

[GitBox <gi...@apache.org>]

andrewluotechnologies commented on a change in pull request #61: ATLAS-3295: Remove unused setup code and documentation
URL: https://github.com/apache/atlas/pull/61#discussion_r335847879
 
 

 ##########
 File path: distro/src/bin/atlas_start.py
 ##########
 @@ -143,13 +135,10 @@ def main():
     web_app_path = os.path.join(web_app_dir, "atlas")
     if (mc.isCygwin()):
         web_app_path = mc.convertCygwinPath(web_app_path)
-    if not is_setup:
-        start_atlas_server(atlas_classpath, atlas_pid_file, jvm_logdir, jvm_opts_list, web_app_path)
-        mc.wait_for_startup(confdir, 300)
-        print "Apache Atlas Server started!!!\n"
-    else:
-        process = mc.java("org.apache.atlas.web.setup.AtlasSetup", [], atlas_classpath, jvm_opts_list, jvm_logdir)
 
 Review comment:
   I don't believe there is a AtlasSetupModule anymore: https://github.com/apache/atlas/tree/master/webapp/src/main/java/org/apache/atlas/web/setup
   
   The purpose of this PR is to entirely remove the -setup option as it doesn't seem to be needed anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services