You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by "Tomaz Muraus (JIRA)" <ji...@apache.org> on 2012/12/12 05:53:22 UTC

[dev] [jira] [Commented] (LIBCLOUD-266) Adding Google Compute Engine Support

    [ https://issues.apache.org/jira/browse/LIBCLOUD-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529623#comment-13529623 ] 

Tomaz Muraus commented on LIBCLOUD-266:
---------------------------------------

First thanks for the patch again!

I did have a look at it a while ago when you initially submitted it and there were some issues I have noticed:

1. Classes aren't old style (they don't inherit from object)
2. "raise Exception" is also deprecated, you should do raise Exception('message') or in most cases throw a more specific exception
3. this patch actually doesn't work by itself because gcelib depends on oauth library which is not installed

I'm not yet sure what's the best way to proceed with regards to #3. We don't want to add any more dependencies to Libcloud for the reasons already discussed in the past.

I'm leaning towards not using gcelib again. I've checked the GCE API docs and there is nothing to insane in it so it wouldn't be that hard to implement it from scratch in Libcloud. Only part which would take a bit more time is authentication (oauth2).
                
> Adding Google Compute Engine Support
> ------------------------------------
>
>                 Key: LIBCLOUD-266
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-266
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>    Affects Versions: 0.11.2
>            Reporter: Ziyad Mir
>            Priority: Minor
>              Labels: patch
>         Attachments: libcloud.patch
>
>
> Adding a new compute driver for Google Compute Engine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira