You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/08/25 11:10:26 UTC

[GitHub] [ignite-3] AMashenkov commented on pull request #282: IGNITE-15253 Tuple API improvement

AMashenkov commented on pull request #282:
URL: https://github.com/apache/ignite-3/pull/282#issuecomment-905404198


   Still, there are open questions.
   1. Should TupleImpl be a part of public API or moved to internal package (core module)
   2. Can we "convert" underlying row to a tuple on very first tuple.set() method call in more optimal way?
   3. Do we really need mutable tuple for a row (or for a key at least)?
    SchemaAware interface on mutable tuple looks confusing.
   On the one hand mutable tuple become NOT schema-aware after the first mutation.
   On the other hand, schema awareness is very useful for client protocol and I can't imagine a case when we need to mutate Tuple with a Row internally.
   With the builder approach it was easy to distinct mutable tuple from a schema-aware one (with a row underneath),
   but for now we need an additional wrapper/object to address this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org