You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/05 02:35:03 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15424: [PIP-163][Txn]Add lowWaterMark check before appending entry to TB

Technoboy- commented on code in PR #15424:
URL: https://github.com/apache/pulsar/pull/15424#discussion_r865519434


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -240,6 +244,13 @@ public CompletableFuture<Void> checkIfTBRecoverCompletely(boolean isTxnEnabled)
     @Override
     public CompletableFuture<Position> appendBufferToTxn(TxnID txnId, long sequenceId, ByteBuf buffer) {
         CompletableFuture<Position> completableFuture = new CompletableFuture<>();
+        if (lowWaterMarks.get(txnId.getMostSigBits()) != null

Review Comment:
   Add a local variable for `lowWaterMarks.get(txnId.getMostSigBits())`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org