[GitHub] afernandez commented on a change in pull request #3697: DI-1113. ADDENDUM. Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[GitBox <gi...@apache.org>]

afernandez commented on a change in pull request #3697: DI-1113. ADDENDUM. Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)
URL: https://github.com/apache/incubator-superset/pull/3697#discussion_r145865028
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -187,26 +187,16 @@ def select_star(cls, my_db, table_name, schema=None, limit=100,
         return sql
 
     @classmethod
-    def modify_url_for_impersonation(cls, url, impersonate_user, username):
+    def get_configuration_for_impersonation(cls, uri, impersonate_user, username):
 
 Review comment:
   Update the configuration dictionary instead of the URL's query dictionary so that we don't have to modify PyHive library.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services