You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/08 09:34:49 UTC

[GitHub] [pulsar] teabot opened a new pull request, #16475: [cleanup][pulsar] Remove warnings when testing deprecated code

teabot opened a new pull request, #16475:
URL: https://github.com/apache/pulsar/pull/16475

   ### Motivation
   We wish to reduce warnings in the build output that don't add value to decrease build noise and generally increase the usefulness of warnings.
   
   ### Modifications
   Tests that target deprecated code clearly have a good reason to do so. We should not generate compiler warnings for such code. In one case a monolithic test case has been split up to better target the warning supression.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   Non-functional change
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] teabot commented on pull request #16475: [cleanup][pulsar] Remove warnings when testing deprecated code

Posted by GitBox <gi...@apache.org>.
teabot commented on PR #16475:
URL: https://github.com/apache/pulsar/pull/16475#issuecomment-1180328716

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #16475: [cleanup][pulsar] Remove warnings when testing deprecated code

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16475:
URL: https://github.com/apache/pulsar/pull/16475


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org