You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Indhumathi27 (via GitHub)" <gi...@apache.org> on 2025/01/05 15:02:05 UTC
[PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Indhumathi27 opened a new pull request, #5595:
URL: https://github.com/apache/hive/pull/5595
### What changes were proposed in this pull request?
Fixed minor bugs in ReplicationMigrationTool and enabled TestReplicationMigrationTool class
### Why are the changes needed?
The testcases were not running properly from beginning and went unnoticed because of lower Maven surefire plugin which suppressed the errors. Post [HIVE-28519](https://issues.apache.org/jira/browse/HIVE-28519) the test cases started failing. Error log is added in the jira.
### Does this PR introduce _any_ user-facing change?
No
### Is the change a dependency upgrade?
No
### How was this patch tested?
Existing test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin merged PR #5595:
URL: https://github.com/apache/hive/pull/5595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5595:
URL: https://github.com/apache/hive/pull/5595#issuecomment-2572327941
@ayushtkn Can you help to review. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5595:
URL: https://github.com/apache/hive/pull/5595#issuecomment-2586202626
@deniskuzZ @ayushtkn @okumin Please help to review the PR. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5595:
URL: https://github.com/apache/hive/pull/5595#issuecomment-2571671536
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5595) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5595&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5595&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5595&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5595&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5595&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5595)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5595:
URL: https://github.com/apache/hive/pull/5595#discussion_r1912728339
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java:
##########
@@ -155,6 +155,9 @@ public int run(String[] args) throws Exception {
System.out.println("Completed verification. Source & Target are " + (failed == 0 ? "in Sync." : "not in Sync."));
System.out.println("Time Taken: " + (System.currentTimeMillis() - startTime) + " ms");
+ if (failed != 0) {
+ return -1;
+ }
Review Comment:
👍
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java:
##########
@@ -359,7 +362,6 @@ public boolean validateAtFileLevel(Path srcDir, Path tgtDir, FileSystem srcFs, F
LocatedFileStatus sourceFile = srcListing.next();
if (filtersPattern != null && !isCopied(sourceFile.getPath(), filtersPattern)) {
LOG.info("Entry: {} is filtered.", sourceFile.getPath());
- continue;
Review Comment:
I understand this is just a cleanup that doesn't change behaviors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on code in PR #5595:
URL: https://github.com/apache/hive/pull/5595#discussion_r1912736916
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java:
##########
@@ -359,7 +362,6 @@ public boolean validateAtFileLevel(Path srcDir, Path tgtDir, FileSystem srcFs, F
LocatedFileStatus sourceFile = srcListing.next();
if (filtersPattern != null && !isCopied(sourceFile.getPath(), filtersPattern)) {
LOG.info("Entry: {} is filtered.", sourceFile.getPath());
- continue;
Review Comment:
you are right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28608: Resolve Issues in ReplicationMigrationTool and Activate Test Suite [hive]
Posted by "Indhumathi27 (via GitHub)" <gi...@apache.org>.
Indhumathi27 commented on PR #5595:
URL: https://github.com/apache/hive/pull/5595#issuecomment-2591657217
@okumin Can you help to check this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org