You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/20 23:40:47 UTC
[GitHub] [airflow] leahecole opened a new pull request #7223: add uuid to
dataflow example
leahecole opened a new pull request #7223: add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7223: [WIP][AIRFLOW-6606]
add uuid to dataflow example
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7223: [WIP][AIRFLOW-6606] add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223#issuecomment-576469040
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=h1) Report
> Merging [#7223](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3730c24c41470cd331c5109539ee2fa0c9f4e74a?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7223 +/- ##
==========================================
- Coverage 85.52% 85.23% -0.29%
==========================================
Files 758 758
Lines 39932 39932
==========================================
- Hits 34150 34038 -112
- Misses 5782 5894 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `100% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7223/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=footer). Last update [3730c24...92cdf71](https://codecov.io/gh/apache/airflow/pull/7223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj closed pull request #7223: [WIP][AIRFLOW-6606]
Add uuid to dataflow example
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #7223: [WIP][AIRFLOW-6606] Add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7223: [WIP][AIRFLOW-6606] Add
uuid to dataflow example
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7223: [WIP][AIRFLOW-6606] Add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223#issuecomment-595298431
Hello,
From what I see, a unique prefix is added to each job_name.
```
:param append_job_name: True if unique suffix has to be appended to job name.
:type append_job_name: bool
```
This option is set by default for operators and hooks. For operators, you cannot turn it off, but for a hook, you have the option to turn it off.
https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/dataflow.py#L563
If I am wrong, I invite you to open the issue again.
Best regards,
Kamil
CC: @jaketf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7223:
[WIP][AIRFLOW-6606] add uuid to dataflow example
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7223: [WIP][AIRFLOW-6606] add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223#discussion_r368930250
##########
File path: airflow/gcp/example_dags/example_dataflow.py
##########
@@ -55,7 +55,7 @@
start_java_job = DataflowCreateJavaJobOperator(
task_id="start-java-job",
jar=GCS_JAR,
- job_name='{{task.task_id}}22222255sss{{ macros.uuid.uuid4() }}',
+ job_name='{{task.task_id}}-{{ macros.uuid.uuid4() }}',
Review comment:
Airflow tasks should be idempoten. Will they still be now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] leahecole commented on issue #7223: [AIRFLOW-XXXX] add
uuid to dataflow example
Posted by GitBox <gi...@apache.org>.
leahecole commented on issue #7223: [AIRFLOW-XXXX] add uuid to dataflow example
URL: https://github.com/apache/airflow/pull/7223#issuecomment-576462644
I'll go create a jira issue now - totally forgot that step, sorry!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services