You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/01/18 13:13:40 UTC
[PR] Remove dead code to fix clippy [arrow-rs]
alamb opened a new pull request, #9215:
URL: https://github.com/apache/arrow-rs/pull/9215
# Which issue does this PR close?
# Rationale for this change
Clippy is failing on main: https://github.com/apache/arrow-rs/actions/runs/21112104909/job/60712213339
```
error: function `get_offsets` is never used
--> arrow-array/src/array/mod.rs:929:11
|
929 | unsafe fn get_offsets<O: ArrowNativeType>(data: &ArrayData) -> OffsetBuffer<O> {
| ^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
```
This is due to a logical conflict with some of my PRs (that migrated to use a different version of this function, and now this one is not used)
# What changes are included in this PR?
remove the unused method
# Are these changes tested?
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dead code to fix clippy failure on main [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9215:
URL: https://github.com/apache/arrow-rs/pull/9215#issuecomment-3765366842
Thank you for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove dead code to fix clippy failure on main [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9215:
URL: https://github.com/apache/arrow-rs/pull/9215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org