[jira] [Commented] (MYRIAD-184) RM Ports are Hardcoded in NMExecutorCLGenImpl.java

["Zachary Jaffee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYRIAD-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170190#comment-15170190 ] 

Zachary Jaffee commented on MYRIAD-184:
---------------------------------------

Opened a PR. https://github.com/apache/incubator-myriad/pull/61

> RM Ports are Hardcoded in NMExecutorCLGenImpl.java
> --------------------------------------------------
>
>                 Key: MYRIAD-184
>                 URL: https://issues.apache.org/jira/browse/MYRIAD-184
>             Project: Myriad
>          Issue Type: Bug
>          Components: Executor
>    Affects Versions: Myriad 0.1.0
>            Reporter: John Omernik
>              Labels: easyfix, newbie
>
> In NMExecutorCLGenImpl.java, the ports for Resource Manager are derived via the http.policy config setting. Instead, the ports should be using a different variable that actually corresponds to running port. The ports that are hard coded are the default ports for the RM for HTTP and HTTPS (8088, and 8090) but if a user changed the port, the config download would fail.   Thus finding a better variable here would help make it so operators are not limited to the default ports in their environments. 
> (Hard Coding in function public String getConfigurationUrl())
> https://github.com/apache/incubator-myriad/blob/df7d05c8639b371b94a1e94406e2f2446d10eaaf/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)