Re: [PR] CKS: handle VPC tiers without attached ACLs [cloudstack]

["sureshanaparti (via GitHub)" <gi...@apache.org>]

sureshanaparti commented on code in PR #13762:
URL: https://github.com/apache/cloudstack/pull/13762#discussion_r3976099420


##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##########
@@ -717,7 +717,7 @@ protected void setupKubernetesClusterIsolatedNetworkRules(IpAddress publicIp, Ne
     }
 
     protected void createVpcTierAclRules(Network network) throws ManagementServerException {
-        if (network.getNetworkACLId() == NetworkACL.DEFAULT_ALLOW) {
+        if (Objects.equals(network.getNetworkACLId(), NetworkACL.DEFAULT_ALLOW)) {

Review Comment:
   should check for network.getNetworkACLId() null here, same as remove case?
   
   ```suggestion
           Long networkAclId = network.getNetworkACLId();
           if (networkAclId == null || Objects.equals(network.getNetworkACLId(), NetworkACL.DEFAULT_ALLOW)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org