You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "shojiiii (via GitHub)" <gi...@apache.org> on 2026/04/28 02:43:14 UTC

[PR] fix(result_set): preserve unicode characters in stringified nested values [superset]

shojiiii opened a new pull request, #39711:
URL: https://github.com/apache/superset/pull/39711

   ### SUMMARY
   
   When nested column values (e.g. `ARRAY<STRING>`) are serialised via
   `stringify()`, the JSON encoder was called with `ensure_ascii=True`
   (the default). This caused all non-ASCII characters — CJK, accented
   Latin, emoji, etc. — to be escaped to `\uXXXX` sequences, making the
   values unreadable in query results.
   
   The fix threads an `ensure_ascii` parameter through `superset.utils.json.dumps`
   (defaulting to `True` for backwards compatibility) and passes
   `ensure_ascii=False` from `result_set.stringify()` so that Unicode
   characters are preserved as-is.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — backend-only change, no UI impact.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   pytest tests/unit_tests/result_set_test.py -v
   ```
   
   New parametrized test `test_stringify_nested_values_preserves_unicode`
   covers ASCII, Japanese (CJK), accented-Latin, and emoji values.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(result_set): preserve unicode characters in stringified nested values [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39711:
URL: https://github.com/apache/superset/pull/39711#issuecomment-4331994412

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(result_set): preserve unicode characters in stringified nested values [superset]

Posted by "shojiiii (via GitHub)" <gi...@apache.org>.
shojiiii closed pull request #39711: fix(result_set): preserve unicode characters in stringified nested values
URL: https://github.com/apache/superset/pull/39711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org