[GitHub] [nifi] ZhewenFu commented on pull request #6525: NIFI-10639 Fix testAddedRowsTwoTables

[GitBox <gi...@apache.org>]

ZhewenFu commented on PR #6525:
URL: https://github.com/apache/nifi/pull/6525#issuecomment-1317673439

   > I'm not sure how this addresses the flakiness of the test. Is this test failing frequently in Github Actions? I don't quite understand how running the runner a second time and verifying no FlowFiles were transferred fixes the test.
   
   * Sorry for the late response. I detected that the test results are flaky using the NonDex tool for catching non-deterministic/flaky tests (https://github.com/TestingResearchIllinois/NonDex).
   
     You may reproduce the nondeterministic behavior using the following steps:
     Clone the repo and cd into it.
   `mvn install -pl modules/configuration-governance -am -DskipTests`
   `mvn -pl modules/configuration-governance test -Dtest=com.ibm.cloud.platform_services.configuration_governance.v1.model.RuleRequestTest#testRuleRequest`
   `mvn -pl modules/configuration-governance edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=com.ibm.cloud.platform_services.configuration_governance.v1.model.RuleRequestTest#testRuleRequest`
   
   * I think I made a mistake in my previous descriptions. I think the real solve of flaky tests lies on the line `runner.setProperty(QueryDatabaseTableRecord.MAX_ROWS_PER_FLOW_FILE, "0");` due to some inconsistent or asychronized reading/writing. But I am not sure about this for now and still diving into the code to see what's the exact cause of this problem. I will let you know when I find more about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org