You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/05 10:01:45 UTC
[GitHub] [inlong] jun0315 opened a new pull request, #5379: [INLONG-5231]:[Improve][CodeStyle] Add spotless to CI
jun0315 opened a new pull request, #5379:
URL: https://github.com/apache/inlong/pull/5379
see https://github.com/apache/inlong/issues/5231
At present, the AOSP format specification is selected for spotless, which should be consistent with the existing format as much as possible. Currently, only spotless apply the manager module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] jun0315 commented on pull request #5379: [INLONG-5231][Improve][CodeStyle] Add spotless to CI
Posted by GitBox <gi...@apache.org>.
jun0315 commented on PR #5379:
URL: https://github.com/apache/inlong/pull/5379#issuecomment-1215360884
checkstyle has a lot to adapt, and I'm still adapting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leosanqing commented on a diff in pull request #5379: [INLONG-5231][Improve][CodeStyle] Add spotless to CI
Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #5379:
URL: https://github.com/apache/inlong/pull/5379#discussion_r946304458
##########
pom.xml:
##########
@@ -250,6 +251,8 @@
<HikariCP.version>4.0.3</HikariCP.version>
<caffeine.version>2.9.3</caffeine.version>
<kafka.clients.version>3.0.0</kafka.clients.version>
+ <!-- JDK1.8 only support google java format 1.7-->
+ <google.java.format.version>1.7</google.java.format.version>
Review Comment:
I can't find a version that says that jdk8 only supports google-java-format1.7 in the official documentation, can you provide the link? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] jun0315 commented on pull request #5379: [INLONG-5231][Improve][CodeStyle] Add spotless to CI
Posted by GitBox <gi...@apache.org>.
jun0315 commented on PR #5379:
URL: https://github.com/apache/inlong/pull/5379#issuecomment-1276446104
Sorry, I find that there are too many content to adapt to. I plan to close this PR for my personal reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] jun0315 closed pull request #5379: [INLONG-5231][Improve][CodeStyle] Add spotless to CI
Posted by GitBox <gi...@apache.org>.
jun0315 closed pull request #5379: [INLONG-5231][Improve][CodeStyle] Add spotless to CI
URL: https://github.com/apache/inlong/pull/5379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org