[GitHub] dianfu commented on issue #7253: [FLINK-11074] [table][tests] Enable harness tests with RocksdbStateBackend and add harness tests for CollectAggFunction

[GitBox <gi...@apache.org>]

dianfu commented on issue #7253: [FLINK-11074] [table][tests] Enable harness tests with RocksdbStateBackend and add harness tests for CollectAggFunction
URL: https://github.com/apache/flink/pull/7253#issuecomment-445206839
 
 
   @twalthr @sunjincheng121 @walterddr  I have added an `AggFunctionHarnessTest` in another way from the current harness test by constructing the operator to test by compiling a sql query which can generate the operator, not by wrapping a hand written GeneratedAggregate directly. I think it has the following benefits:
   1) The harness test can also cover AggregateCodeGenerator as the operator is now code generated
   2) Writing a new harness test becomes easy. We just need to construct a sql query which can generate the operator we want to test
   3) We are able to test if the DataView is actually replaced with StateDataView
   
   Currently I have not changed other harness tests. We can improve other harness in this way in the following PRs if we are sure this direction is correct.
   
   Could you help to take a look at this PR? Thanks a lot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services