You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/06/07 01:14:39 UTC

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 )

Change subject: IMPALA-8633 : Insert event should not error when table does not exists
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13548/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/13548/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@631
PS2, Line 631:       msTbl = metaStoreClient.getHiveClient().getTable(TEST_DB_NAME, createInsertDropTable);
> line too long (92 > 90)
Done


http://gerrit.cloudera.org:8080/#/c/13548/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@739
PS2, Line 739:     Path parentPath = partition == null ? new Path(msTbl.getSd().getLocation()) : new Path(partition.getSd().getLocation());
> line too long (124 > 90)
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I961cd7cbede4c248dba538c7fabb4bc708e49693
Gerrit-Change-Number: 13548
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 01:14:39 +0000
Gerrit-HasComments: Yes