You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/05/16 22:00:01 UTC
[kudu-CR] net util: add a counter for time spent in DNS lookups
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6906
to review the following change.
Change subject: net_util: add a counter for time spent in DNS lookups
......................................................................
net_util: add a counter for time spent in DNS lookups
Recently I've seen some issues where DNS lookups were made in the
context of an RPC. This adds a trace counter to sum the latency spent
in DNS lookups.
Change-Id: I244c97509f4c77844441106afb58e146e907f3d9
---
M src/kudu/util/net/net_util.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/6906/1
--
To view, visit http://gerrit.cloudera.org:8080/6906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I244c97509f4c77844441106afb58e146e907f3d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] net util: add a counter for time spent in DNS lookups
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: net_util: add a counter for time spent in DNS lookups
......................................................................
net_util: add a counter for time spent in DNS lookups
Recently I've seen some issues where DNS lookups were made in the
context of an RPC. This adds a trace counter to sum the latency spent
in DNS lookups.
Change-Id: I244c97509f4c77844441106afb58e146e907f3d9
Reviewed-on: http://gerrit.cloudera.org:8080/6906
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/net/net_util.cc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I244c97509f4c77844441106afb58e146e907f3d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] net util: add a counter for time spent in DNS lookups
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: net_util: add a counter for time spent in DNS lookups
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I244c97509f4c77844441106afb58e146e907f3d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No