You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/03/28 19:59:52 UTC

[GitHub] [drill] cgivre opened a new pull request #2507: DRILL-8180: Add Icons to Storage Plugin List

cgivre opened a new pull request #2507:
URL: https://github.com/apache/drill/pull/2507


   # [DRILL-8180](https://issues.apache.org/jira/browse/DRILL-XXXX): Add Icons to Storage Plugin List
   
   ## Description
   
   ## Documentation
   This PR adds icons to the storage plugin list depending on the type of storage plugin.  See screenshot below.
   
   ![Screen Shot 2022-03-28 at 3 56 36 PM](https://user-images.githubusercontent.com/5513150/160477190-ae0e8813-c01c-4329-bf18-08428fc13623.png)
   
   
   ## Testing
   Tested manually


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2507: DRILL-8180: Add Icons to Storage Plugin List

Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2507:
URL: https://github.com/apache/drill/pull/2507#issuecomment-1081615480


   Nice touch.  I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon.  Let me know if I can help out here by hitting them with the GIMP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #2507: DRILL-8180: Add Icons to Storage Plugin List

Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on pull request #2507:
URL: https://github.com/apache/drill/pull/2507#issuecomment-1081865395


   When running java application, resources from all places that are in class path should be accessible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2507: DRILL-8180: Add Icons to Storage Plugin List

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2507:
URL: https://github.com/apache/drill/pull/2507#issuecomment-1081786004


   > Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP.
   
   I would really appreciate that.  I don't actually have image editing software on my machine, or experience with the GIMP.  Also, if you don't like any of the icons, feel free to change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2507: DRILL-8180: Add Icons to Storage Plugin List

Posted by GitBox <gi...@apache.org>.
cgivre commented on pull request #2507:
URL: https://github.com/apache/drill/pull/2507#issuecomment-1081860322


   > Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?
   
   I suppose so, but I'm not quite sure how you would do that.  All the Drill REST server components (to include static resources) are contained in `java-exec`.   Any ideas? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org