[GitHub] [zookeeper] merlimat opened a new pull request #1441: ZOOKEEPER-3923: Retry following reader after connection read error

[GitBox <gi...@apache.org>]

merlimat opened a new pull request #1441:
URL: https://github.com/apache/zookeeper/pull/1441


   Performs retries in syncing up with leader, in order to handle cases in which the TCP connection is established but immediately closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] merlimat commented on pull request #1441: ZOOKEEPER-3923: Retry following reader after connection read error

[GitBox <gi...@apache.org>]

merlimat commented on pull request #1441:
URL: https://github.com/apache/zookeeper/pull/1441#issuecomment-682965401


   > We should add some test.
   
   I agree, though I'm not sure how to trigger this particular issue. Is there any support in tests to simulate network issues?
   
   > Probably it would be better to make it configurable the number of retries but I don't feel strong about it
   
   Yes, we can make it configurable. I was just following the same pattern as in 
   https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java#L410


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org