You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Varun Thacker (Jira)" <ji...@apache.org> on 2020/09/01 23:01:00 UTC

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

    [ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188851#comment-17188851 ] 

Varun Thacker commented on LUCENE-9497:
---------------------------------------

Here is the first warning withing lucene core that this tool found

 
{code:java}
/Users/vthacker/apache-work/lucene-solr/lucene/core/src/java/org/apache/lucene/search/DocIdSetIterator.java:130: warning: [IntLongMath] Expression of type int may overflow before being assigned to a long
        return maxDoc - minDoc;
                      ^
    (see https://errorprone.info/bugpattern/IntLongMath)
  Did you mean 'return (long) maxDoc - minDoc;'?
error: warnings found and -Werror specified
1 error
1 warning
{code}

> Integerate Error Prone ( Static Analysis Tool ) during compilation
> ------------------------------------------------------------------
>
>                 Key: LUCENE-9497
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9497
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Varun Thacker
>            Priority: Minor
>
> Integrate [https://github.com/google/error-prone] during compilation of our source code to catch mistakes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org