You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/31 05:54:22 UTC

[GitHub] [incubator-gobblin] autumnust opened a new pull request #2656: [GOBBLIN-790]DagStateStore MySQL

autumnust opened a new pull request #2656: [GOBBLIN-790]DagStateStore MySQL
URL: https://github.com/apache/incubator-gobblin/pull/2656
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA]
       - https://issues.apache.org/jira/browse/GOBBLIN-790
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   This is the implementation of `DagStateStore` backed by MySQL. 
   Instead of implementing its own MySQLl-related logic, it instantiate a `MySQLStateStore` inside the DagStateStore and delegate all interactions between MySQL to that. To archive this, also added: 
   - Conversion from `Dag` to `State` by having `Dag` serialized first and put it as a value in State's k-v pair. 
   - `getAll` method in `MysqlStateStore` where it used to strictly require `storeName` to show up. 
   - Model the schema of `MysqlStateStore`  in the `Dag'gy way: `FlowId` <--> `storeName`,  `FlowExecutionId` <--> `tableName`. 
   - Refactor some of test methods to reduce code redundancy. 
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   - Relevant unit tests are added. 
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services