[GitHub] [hbase] petersomogyi commented on a diff in pull request #5020: HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner

["petersomogyi (via GitHub)" <gi...@apache.org>]

petersomogyi commented on code in PR #5020:
URL: https://github.com/apache/hbase/pull/5020#discussion_r1104204516


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java:
##########
@@ -97,6 +98,8 @@ Collection<String> filesUnderSnapshot(final FileSystem fs, final Path snapshotDi
   private ImmutableMap<String, SnapshotDirectoryInfo> snapshots = ImmutableMap.of();
   private final Timer refreshTimer;
 
+  private static final int LOCK_TIMEOUT_MS = 30000;

Review Comment:
   After HBASE-27590 I don't think it is necessary because the locking time is drastically reduced. Earlier I have seen the `Failed to acquire write lock on taking snapshot after waiting 60000ms` WARN messages continuously on this cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org