[jira] [Commented] (JENA-359) inModel() dependencies on ModelCom

["Andy Seaborne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508238#comment-13508238 ] 

Andy Seaborne commented on JENA-359:
------------------------------------

Why not just remove the casts?  getRDFNode in the interface ModelCon.

More generally, what required an implementation of Model that can't be done by an implementation of Graph?
                
> inModel() dependencies on ModelCom
> ----------------------------------
>
>                 Key: JENA-359
>                 URL: https://issues.apache.org/jira/browse/JENA-359
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Jena
>    Affects Versions: Jena 2.7.4
>            Reporter: Claude Warren
>
> LiteralImpl.inModel( Model m ) and ResourceImpl.inModel( Model m ) cast the Model m to a ModelCom in some instances.
> ResourecImpl.inModel() calls
> asNode().isConcrete() == false ? (Resource) ((ModelCom) m).getRDFNode( asNode() )
> this line handles working with variables and I am not sure how to fix that.
> LiteralImpl.inModel()  calls
> (Literal) ((ModelCom) m).getRDFNode( asNode() )
> I think this can be replaced with
> m.createTypedLiteral(getLexicalForm(), getDataType())
> My issue is that I have a model implementation that does not derive from ModelCom so these methods fail some test cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira