You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/07/09 19:45:06 UTC
[jira] [Commented] (YARN-2264) Race in DrainDispatcher can cause
random test failures
[ https://issues.apache.org/jira/browse/YARN-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056504#comment-14056504 ]
Hadoop QA commented on YARN-2264:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12654838/YARN-2264-070814.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4238//console
This message is automatically generated.
> Race in DrainDispatcher can cause random test failures
> ------------------------------------------------------
>
> Key: YARN-2264
> URL: https://issues.apache.org/jira/browse/YARN-2264
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Siddharth Seth
> Assignee: Li Lu
> Attachments: YARN-2264-070814.patch
>
>
> This is what can happen.
> This is the potential race.
> DrainDispatcher is started via serviceStart() . As a last step, this starts the actual dispatcher thread (eventHandlingThread.start() - and returns immediately - which means the thread may or may not have started up by the time start returns.
> Event sequence:
> UserThread: calls dispatcher.getEventHandler().handle()
> This sets drained = false, and a context switch happens.
> DispatcherThread: starts running
> DispatcherThread drained = queue.isEmpty(); -> This sets drained to true, since Thread1 yielded before putting anything into the queue.
> UserThread: actual.handle(event) - which puts the event in the queue for the dispatcher thread to process, and returns control.
> UserThread: dispatcher.await() - Since drained is true, this returns immediately - even though there is a pending event to process.
--
This message was sent by Atlassian JIRA
(v6.2#6252)