[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2207: HADOOP-17074 Optimise s3a Listing to be fully asynchronous.

[GitBox <gi...@apache.org>]

mukund-thakur commented on a change in pull request #2207:
URL: https://github.com/apache/hadoop/pull/2207#discussion_r469837444



##########
File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3ADirectoryPerformance.java
##########
@@ -137,6 +159,78 @@ public void testListOperations() throws Throwable {
     }
   }
 
+  @Test
+  public void testMultiPagesListingPerformanceAndCorrectness() throws Throwable {
+    describe("Check performance and correctness for multi page listing " +
+            "using different listing api");
+    Path dir = path(this.getMethodName());
+    Configuration conf = getConfigurationWithConfiguredBatchSize(10);
+    fs = (S3AFileSystem) FileSystem.get(dir.toUri(), conf);

Review comment:
       Initially there were two tests so I thought of reusing the class level variable and closing the fs in teardown. 
   Since there is just one test, I have moved to a local variable and closing using try-with-resources.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org