You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/01 13:15:49 UTC
[GitHub] [rocketmq] wqliang commented on a change in pull request #1734:
[ISSUE #1727] fix RequestCallback executed multi times
wqliang commented on a change in pull request #1734: [ISSUE #1727] fix RequestCallback executed multi times
URL: https://github.com/apache/rocketmq/pull/1734#discussion_r386107376
##########
File path: client/src/main/java/org/apache/rocketmq/client/producer/RequestResponseFuture.java
##########
@@ -39,7 +41,7 @@ public RequestResponseFuture(String correlationId, long timeoutMillis, RequestCa
}
public void executeRequestCallback() {
- if (requestCallback != null) {
+ if (requestCallback != null && executeCallbackOnlyOnce.compareAndSet(false, true)) {
Review comment:
I have pulled the latest code from 'develop' branch and not very sure what you mean here, could you plz give me more details?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services