[GitHub] [ozone] adoroszlai commented on a diff in pull request #3908: HDDS-7321. Auto rocksDB small sst files compaction.

[GitBox <gi...@apache.org>]

adoroszlai commented on code in PR #3908:
URL: https://github.com/apache/ozone/pull/3908#discussion_r1008360825


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -358,6 +358,31 @@ public void setWaitOnAllFollowers(boolean val) {
   )
   private int rocksdbMaxOpenFiles = ROCKSDB_MAX_OPEN_FILES_DEFAULT;
 
+  @Config(key = "rocksdb.auto-compaction-small-sst-file",

Review Comment:
   @myskov these config annotations are generated at compile time into XML format (search for `ozone-default-generated.xml` after build).  They should not be added manually to `ozone-default.xml`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org