You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/18 23:18:00 UTC

[jira] [Commented] (AIRFLOW-3730) Improper use of logs mechanisms.

    [ https://issues.apache.org/jira/browse/AIRFLOW-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746765#comment-16746765 ] 

ASF GitHub Bot commented on AIRFLOW-3730:
-----------------------------------------

mik-laj commented on pull request #4556: [AIRFLOW-3730] Standarization use of logs mechanisms
URL: https://github.com/apache/airflow/pull/4556
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3730
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   Some operators did not use the logging mechanism from Airflow, but used the Python mechanism.
   Some operators extend the 'LoggingMixin' class when it is not needed.
   This change standardizes these changes.
   
   ### Tests
   
   I'm not introducing new changes. Only rewrites the code.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improper use of logs mechanisms.
> --------------------------------
>
>                 Key: AIRFLOW-3730
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3730
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Kamil Bregula
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)