You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "amfysky (via GitHub)" <gi...@apache.org> on 2026/03/17 06:06:44 UTC

[I] Improve the performance of merging config [pulsar]

amfysky opened a new issue, #25333:
URL: https://github.com/apache/pulsar/issues/25333

   ### Search before reporting
   
   - [x] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   It is extremely inefficient to convert Object by using json String.
   
   This action just like using `JSON.stringify` and `JSON.parse` to deep clone in JavaScript instead of `lodash`.
   
   ### Solution
   
   Replace `writeValueAsString` and `readValue` with `convertValue`
   
   <img width="695" height="401" alt="Image" src="https://github.com/user-attachments/assets/67de7456-4988-4e69-b3d0-cd4075486832" />
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [x] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve the performance of merging config [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed issue #25333: Improve the performance of merging config
URL: https://github.com/apache/pulsar/issues/25333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve the performance of merging config [pulsar]

Posted by "amfysky (via GitHub)" <gi...@apache.org>.
amfysky commented on issue #25333:
URL: https://github.com/apache/pulsar/issues/25333#issuecomment-4087565253

   > > It is extremely inefficient to convert Object by using json String.
   > 
   > [@amfysky](https://github.com/amfysky) Just wondering the motivation? Are you experiencing a performance issue related to this inefficiency? Or, are you looking for something to contribute in Pulsar?
   > 
   > For changes like this, it could be useful to run Pulsar CI in your own fork, please check the [Personal CI](https://pulsar.apache.org/contribute/personal-ci/) instructions.
   
   When the config is too large, this way will use more memory and calculation.
   This is a potential issue that could affect low-performance servers.
   
   **Original**: Object -> JsonNode -> String -> JsonNode -> Map
   **New**: Object -> JsonNode -> Map
   
   https://github.com/amfysky/pulsar/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve the performance of merging config [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #25333:
URL: https://github.com/apache/pulsar/issues/25333#issuecomment-4084149193

   > It is extremely inefficient to convert Object by using json String.
   
   @amfysky Just wondering the motivation? Are you experiencing a performance issue related to this inefficiency? Or, are you looking for something to contribute in Pulsar?
   
   For changes like this, it could be useful to run Pulsar CI in your own fork, please check the [Personal CI](https://pulsar.apache.org/contribute/personal-ci/) instructions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve the performance of merging config [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #25333:
URL: https://github.com/apache/pulsar/issues/25333#issuecomment-4336904259

   There's no need for this since this isn't a performance hotspot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org