You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Chris Tsai <ct...@users.sf.net> on 2013/12/19 16:01:52 UTC
[allura:tickets] #7007 REST: install_tool:mount_point restrictions are not
same as via web interface [ss6309]
---
** [tickets:#7007] REST: install_tool:mount_point restrictions are not same as via web interface [ss6309]**
**Status:** open
**Labels:** support p3
**Created:** Thu Dec 19, 2013 03:01 PM UTC by Chris Tsai
**Last Updated:** Thu Dec 19, 2013 03:01 PM UTC
**Owner:** nobody
[forge:site-support:#6309]
>Following up on the cygwin-ports upgrade:
>I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):
> if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Incorrect mount point name, or mount point already exists.'
}
>Should that not be something like this instead:
> if c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Mount point already exists.'
}
if not h.re_relaxed_tool_mount_point.match(mount_point):
return {'success': False,
'info': 'Incorrect mount point name.'
}
>IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7007 REST: install_tool:mount_point restrictions are not
same as via web interface [ss6309]
Posted by Cory Johns <ma...@users.sf.net>.
Refactored so that existing validation is used.
---
** [tickets:#7007] REST: install_tool:mount_point restrictions are not same as via web interface [ss6309]**
**Status:** closed
**Labels:** support p3
**Created:** Thu Dec 19, 2013 03:01 PM UTC by Chris Tsai
**Last Updated:** Fri Dec 20, 2013 04:23 PM UTC
**Owner:** Cory Johns
[forge:site-support:#6309]
>Following up on the cygwin-ports upgrade:
>I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):
> if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Incorrect mount point name, or mount point already exists.'
}
>Should that not be something like this instead:
> if c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Mount point already exists.'
}
if not h.re_relaxed_tool_mount_point.match(mount_point):
return {'success': False,
'info': 'Incorrect mount point name.'
}
>IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7007 REST: install_tool:mount_point restrictions are not
same as via web interface [ss6309]
Posted by Cory Johns <ma...@users.sf.net>.
- **QA**: Cory Johns
---
** [tickets:#7007] REST: install_tool:mount_point restrictions are not same as via web interface [ss6309]**
**Status:** code-review
**Labels:** support p3
**Created:** Thu Dec 19, 2013 03:01 PM UTC by Chris Tsai
**Last Updated:** Fri Dec 20, 2013 02:51 PM UTC
**Owner:** nobody
[forge:site-support:#6309]
>Following up on the cygwin-ports upgrade:
>I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):
> if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Incorrect mount point name, or mount point already exists.'
}
>Should that not be something like this instead:
> if c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Mount point already exists.'
}
if not h.re_relaxed_tool_mount_point.match(mount_point):
return {'success': False,
'info': 'Incorrect mount point name.'
}
>IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7007 REST: install_tool:mount_point restrictions are not
same as via web interface [ss6309]
Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: open --> code-review
---
** [tickets:#7007] REST: install_tool:mount_point restrictions are not same as via web interface [ss6309]**
**Status:** code-review
**Labels:** support p3
**Created:** Thu Dec 19, 2013 03:01 PM UTC by Chris Tsai
**Last Updated:** Thu Dec 19, 2013 03:01 PM UTC
**Owner:** nobody
[forge:site-support:#6309]
>Following up on the cygwin-ports upgrade:
>I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):
> if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Incorrect mount point name, or mount point already exists.'
}
>Should that not be something like this instead:
> if c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Mount point already exists.'
}
if not h.re_relaxed_tool_mount_point.match(mount_point):
return {'success': False,
'info': 'Incorrect mount point name.'
}
>IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #7007 REST: install_tool:mount_point restrictions are not
same as via web interface [ss6309]
Posted by Cory Johns <ma...@users.sf.net>.
- **status**: code-review --> closed
- **assigned_to**: Cory Johns
- **Size**: --> 1
- **Milestone**: limbo --> forge-dec-27
---
** [tickets:#7007] REST: install_tool:mount_point restrictions are not same as via web interface [ss6309]**
**Status:** closed
**Labels:** support p3
**Created:** Thu Dec 19, 2013 03:01 PM UTC by Chris Tsai
**Last Updated:** Fri Dec 20, 2013 04:23 PM UTC
**Owner:** Cory Johns
[forge:site-support:#6309]
>Following up on the cygwin-ports upgrade:
>I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):
> if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Incorrect mount point name, or mount point already exists.'
}
>Should that not be something like this instead:
> if c.project.app_instance(mount_point) is not None:
return {'success': False,
'info': 'Mount point already exists.'
}
if not h.re_relaxed_tool_mount_point.match(mount_point):
return {'success': False,
'info': 'Incorrect mount point name.'
}
>IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.
---
Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.