You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Vitor-Avila (via GitHub)" <gi...@apache.org> on 2024/11/28 23:05:37 UTC
[PR] fix(embedded): Hide anchor links in embedded mode [superset]
Vitor-Avila opened a new pull request, #31194:
URL: https://github.com/apache/superset/pull/31194
### SUMMARY
The `Tab` and `Header` UI elements in the dashboard have an `AnchorLink`. These are currently visible in embedded mode. Embedded users are external that don't have access to the instance directly, so these links should not be visible.
This PR hides `AnchorLinks` in embedded mode.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before**
**After**
### TESTING INSTRUCTIONS
Tests added. For manual testing:
1. Create a dashboard containing at least a header and a tab.
2. Load this dashboard in embedded mode.
3. Validate the `AnchorLinks` are not visible.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): Hide anchor links in embedded mode [superset]
Posted by "Rattlyy (via GitHub)" <gi...@apache.org>.
Rattlyy commented on PR #31194:
URL: https://github.com/apache/superset/pull/31194#issuecomment-3533494410
This broke permalinks on embedded dashboards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): Hide anchor links in embedded mode [superset]
Posted by "Rattlyy (via GitHub)" <gi...@apache.org>.
Rattlyy commented on PR #31194:
URL: https://github.com/apache/superset/pull/31194#issuecomment-3541212711
> > This broke permalinks on embedded dashboards.
>
> @Rattlyy this has been closed and pushed to prod for quite a few releases. Mind creating a new issue with repro steps.
#36132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): Hide anchor links in embedded mode [superset]
Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila merged PR #31194:
URL: https://github.com/apache/superset/pull/31194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(embedded): Hide anchor links in embedded mode [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #31194:
URL: https://github.com/apache/superset/pull/31194#issuecomment-3533803667
> This broke permalinks on embedded dashboards.
@Rattlyy this has been closed and pushed to prod for quite a few releases. Mind creating a new issue with repro steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org