[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #554: MINIFICPP-842 - CivetWeb tests should use random port

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #554: MINIFICPP-842 - CivetWeb tests should use random port
URL: https://github.com/apache/nifi-minifi-cpp/pull/554#discussion_r284240253
 
 

 ##########
 File path: extensions/civetweb/processors/ListenHTTP.cpp
 ##########
 @@ -27,11 +27,22 @@ namespace minifi {
 namespace processors {
 
 core::Property ListenHTTP::BasePath(
-    core::PropertyBuilder::createProperty("Base Path")->withDescription("Base path for incoming connections")->isRequired(false)->withDefaultValue<std::string>("contentListener")->build());
+    core::PropertyBuilder::createProperty("Base Path")->
 
 Review comment:
   I know we don't quite yet lint extensions ( this will happen soon ) but I'm pretty sure this will need //NOLINT if you intend to keep it this way. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services