[GitHub] [hudi] danny0405 commented on a diff in pull request #7801: [HUDI-5657] Fix NPE if filters condition contains null literal when using column stats data skipping for flink

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7801:
URL: https://github.com/apache/hudi/pull/7801#discussion_r1095385764


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/stats/TestExpressionEvaluator.java:
##########
@@ -103,8 +108,9 @@ void testEqualTo() {
     equalTo.bindColStats(indexRow6, queryFields(2), rExpr);
     assertFalse(equalTo.eval(), "12 <> null");
 
-    equalTo.bindVal(new ValueLiteralExpression(null, DataTypes.INT()));
-    assertFalse(equalTo.eval(), "null <> null");
+    assertThrows(
+        IllegalStateException.class,

Review Comment:
   Not quite understand why it throws here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org