[GitHub] [tvm] Mousius commented on a change in pull request #10003: [CI] Separate out microTVM demo script

[GitBox <gi...@apache.org>]

Mousius commented on a change in pull request #10003:
URL: https://github.com/apache/tvm/pull/10003#discussion_r789589104



##########
File path: tests/scripts/task_ci_setup.sh
##########
@@ -39,3 +39,6 @@ python3 -m pip install --user tlcpack-sphinx-addon==0.2.1 synr==0.6.0
 
 # Ensure no stale pytest-results remain from a previous test run.
 (cd build && rm -rf pytest-results)
+
+# Install tvm as a local package to allow tvmc to work
+python3 -m pip install --user -e ./python

Review comment:
       > maybe a better strategy is to python3 -mtvm.driver.tvmc in run_demo.sh above, and just comment that this way is used to avoid these problems?
   
   This is what we currently have and what I'm hoping to fix as we shouldn't be exposing any implementation detail of TVM to a user as part of running a tutorial or demo. Given this is ran in `task_ci_setup.sh`, shouldn't this only be ran as part of CI and we should fix CI not using a clean environment if that's a concern?
   
   Another potential way is we can hide it with something like `alias tvmc="python3 -mtvm.driver.tvmc"` in the CI script which at least hides the CI setup from the user? Thoughts on that approach @areusch ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org