[GitHub] [ozone] xBis7 commented on pull request #4057: HDDS-7576. Prometheus metrics do not remove stale metrics until restart

[GitBox <gi...@apache.org>]

xBis7 commented on PR #4057:
URL: https://github.com/apache/ozone/pull/4057#issuecomment-1348985085

   @kerneltime Most methods from `TestPrometheusMetricsSink` actually belong to an integration test. 
   
   This class should only be testing `PrometheusMetricsSink` but instead it's executing a bunch of classes from the hadoop-commons jar. `testNamingCamelCase(), testNamingRocksDB(), testNamingPipeline(), testNamingSpaces()` are unit tests for `PrometheusMetricsSink`, the rest of the methods don't belong in this class.
   
   Also, if you try to publish the metrics more than once, you get `Prometheus has a full queue and can't consume the given metrics.` and the second publish never gets processed.
   
   I think we should cleanup and refactor `TestPrometheusMetricsSink` as part of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org