[GitHub] [hive] nrg4878 commented on a change in pull request #2248: HIVE-25091: Implemented connector provider for MSSQL and Oracle

[GitBox <gi...@apache.org>]

nrg4878 commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r636624386



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -172,10 +172,12 @@ protected Connection getConnection() {
     ResultSet rs = null;
     Table table = null;
     try {
-      // rs = fetchTableMetadata(tableName);
-      rs = fetchTableViaDBMetaData(tableName);
+      rs = fetchTableMetadata(tableName);

Review comment:
       I am not sure I understand this change. Dont we want to use fetchTableViaDBmetadata? we comment out the implementation in the abstract class and moved it into subclasses. can you please expand on your changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org