You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/23 14:46:54 UTC
[GitHub] [superset] aleksandrgordienko opened a new issue #15866: Error while uploading Excel without all_database_access
aleksandrgordienko opened a new issue #15866:
URL: https://github.com/apache/superset/issues/15866
There is a bug in the code. Superset crashes when you are trying to open the Upload Excel form from a user account without `all_database_access` permissions.
### Expected results
Upload Excel form opened and can be used for file upload.
### Actual results
Superset crashes because of the absence of `schemas_accessible_by_user()` method in `SupersetSecurityManager` class. The error is in the `superset/views/database/forms.py`. Correct method name must be `**get_**schemas_accessible_by_user()`
#### Screenshots
Haven't made any, sorry:)
#### How to reproduce the bug
1. Create database connection with upload support
2. Create user with Gamma role + permission for Excel uploading + permission for database
3. Try to open the Upload Excel form from the menu
4. See the error
### Environment
- superset version: 1.1.0 (but I see the same problem in 1.2.0 and master too)
- python version: 3.7.9
- node.js version: not relevant
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces, but didn't include any, sorry again :)
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
I can solve the problem by myself and make a pull request later. I've created this issue as it's written in [CONTRIBUTING.md](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#fix-bugs):
> Before creating a PR, create an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #15866: Error while uploading Excel without all_database_access
Posted by GitBox <gi...@apache.org>.
villebro closed issue #15866:
URL: https://github.com/apache/superset/issues/15866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15866: Error while uploading Excel without all_database_access
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15866:
URL: https://github.com/apache/superset/issues/15866#issuecomment-885907912
Taking a look 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15866: Error while uploading Excel without all_database_access
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15866:
URL: https://github.com/apache/superset/issues/15866#issuecomment-971457912
This has been fixed by #16756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org