You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/25 15:20:11 UTC
[GitHub] [cloudstack-primate] ravening opened a new pull request #459: Display tab showing the current resource count for domain
ravening opened a new pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459
Currenlty "Domain Admins" cannot see how much resources
they are consuming for their domain.
So display a "Resource Count" tab which displays the
current usage and the total allocated resoures
Also fix the display error for "parentdomainname" label
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653551845
> @ravening This looks good, can you treat -1 as unlimited and display it accordingly?
@davidjumani I didnt see "-1" in the output of listDomains or listAccounts or listProjects. It returns "Unlimited" instead of -1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653470710
@ravening This looks good, can you treat -1 as unlimited and display it accordingly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-651207536
> @ravening here are some feedback and ideas:
>
> * Rename the tab to Resource or something like Usage?
> * Could you make it reusable, as it's the same concept for account and projects (similar to the limits tab)
> * If we need to show the current resource count/usage in a different tab, remove it from the details tab (do it for accounts and projects as well)
> * See Infra -> zone -> resources tab which shows capacities/resource count for zones; you may even show progress bar like widgets (we know current and total usage, to show a percentage for example)
@rhtyd
Im not sure how to display the progress bar properly as most of the resources will be "-1" for root domain and other domains. In that case what value should I use for denominator?
In the details tab they just iterate over the values in the array. So it might be difficult to remove the details from there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-649633362
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/459 (JID-2133)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653350037
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-651688491
@ravening we can skip those or show a progress bar with no progress (0%) as the limit is unlimited?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-649626505
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653354096
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/459 (JID-2198)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653553808
@ravening Perhaps it's an older version, could you handle this too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-649719677
@ravening here are some feedback and ideas:
- Rename the tab to Resource or something like Usage?
- Could you make it reusable, as it's the same concept for account and projects (similar to the limits tab)
- If we need to show the current resource count/usage in a different tab, remove it from the details tab (do it for accounts and projects as well)
- See Infra -> zone -> resources tab which shows capacities/resource count for zones; you may even show progress bar like widgets (we know current and total usage, to show a percentage for example)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-649719677
@ravening here some feedback and ideas:
- Rename the tab to Resource or something like Usage?
- Could you make it reusable, as it's the same concept for account and projects (similar to the limits tab)
- If we need to show the current resource count/usage in a different tab, remove it from the details tab (do it for accounts and projects as well)
- See Infra -> zone -> resources tab which shows capacities/resource count for zones; you may even show progress bar like widgets (we know current and total usage, to show a percentage for example)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-652922816
@rhtyd I made the proper changes showing progress bar as well for Domains/accounts/projects
Please review again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653350566
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653728951
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #459: Display tab showing the current resource count for domain
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #459:
URL: https://github.com/apache/cloudstack-primate/pull/459#issuecomment-649625529
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org