[GitHub] [flink] chucheng92 commented on a diff in pull request #21917: [FLINK-31015][connectors/common] Fix SplitReader doesn't extends AutoCloseable but implements close method

["chucheng92 (via GitHub)" <gi...@apache.org>]

chucheng92 commented on code in PR #21917:
URL: https://github.com/apache/flink/pull/21917#discussion_r1105296100


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitReader.java:
##########
@@ -33,7 +33,7 @@
  * @param <SplitT> the split type.
  */
 @PublicEvolving
-public interface SplitReader<E, SplitT extends SourceSplit> {
+public interface SplitReader<E, SplitT extends SourceSplit> extends AutoCloseable {

Review Comment:
   @XComp thanks. i have updated this pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org