You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/06 19:54:06 UTC

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #303: Close msg channel when consumer close

cckellogg commented on a change in pull request #303:
URL: https://github.com/apache/pulsar-client-go/pull/303#discussion_r450446421



##########
File path: pulsar/consumer_impl.go
##########
@@ -374,6 +374,7 @@ func (c *consumer) Close() {
 		}
 		wg.Wait()
 		close(c.closeCh)
+		close(c.messageCh)

Review comment:
       If the user passes in a channel and the channel is shared close could be called multiple times and there will be a panic.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org