You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by albertostratio <gi...@git.apache.org> on 2015/04/28 13:22:18 UTC
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
GitHub user albertostratio opened a pull request:
https://github.com/apache/metamodel/pull/21
Add LIKE operator support. Fixes #METAMODEL-136
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ardlema/metamodel 136-like-mongodb
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit 2787d0909d4ab0cc52b55b4815b380621ec788a5
Author: Alberto Rodriguez <ar...@stratio.com>
Date: 2015-04-28T11:19:01Z
Add LIKE operator support. Fixes #METAMODEL-136
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97383930
Minor issue addressed. ping @LosD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97389873
Though Travis seems to have failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97392070
I'm pretty sure it's not a problem; both Java 7 & 8 completes successfully, and (much unlike the ES code) there is nothing in this code that should be affected by the JDK version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97390210
Okay, seems unrelated (ElasticSearch). @kaspersorensen also mentioned that we have had Travis problems with ES, so still good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97376262
Changes suggested by @LosD implemented. Thank you again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29260399
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +441,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
+
+ private String replaceWildCardLikeChars(String operand) {
+ return operand.replace("%","");
--- End diff --
Good point! I agree we should take care of cases like that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97404628
Looks good, I'll push it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29234623
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -408,7 +414,7 @@ private void convertToCursorObject(BasicDBObject query, FilterItem item) {
private String getOperatorName(FilterItem item) {
final String operatorName;
switch (item.getOperator()) {
- case EQUALS_TO:
+ case EQUALS_TO: case LIKE:
--- End diff --
looks strange without a linebreak here I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29246239
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +441,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
+
+ private String replaceWildCardLikeChars(String operand) {
+ return operand.replace("%","");
--- End diff --
Yes, you are right, is just removing the %. I think we don't need to add more complexity to the regular expression, when we'd receive a string like '%MALE%' we just need to create a pattern like this (removing the %):
```
Pattern j = Pattern.compile("MALE", Pattern.CASE_INSENSITIVE);
```
Whereas when we'd receive a string like 'MALE%' the pattern should be (removing % and prepend ^):
```
Pattern j = Pattern.compile("^MALE", Pattern.CASE_INSENSITIVE);
```
I think these are the only cases we should care about. Both are working fine as tested in the test I've added.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97391445
Yes, not sure what's going on with Travis but I've seen some builds of the PR "green"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29323171
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +442,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
--- End diff --
Really good point in here! I've just modified the code to always prepend ^ and append $ and the tests are all passing OK. Thank you for the comment! I'll be pushing the changes right now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29253869
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +441,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
+
+ private String replaceWildCardLikeChars(String operand) {
+ return operand.replace("%","");
--- End diff --
I think we also need to cater to cases like ```WHERE name LIKE '% Alberto % Stratio %'```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97333860
I agree, we should be using replaceAll instead of replace but I think we need to keep the if in the turnOperandIntoRegExp method to prepend "^" when the like operand is like "MALE%" (pick up just elements starting with MALE). If we remove this condition we will pick up ALWAYS every string with the MALE substring in it and this is not what we want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29241616
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -408,7 +414,7 @@ private void convertToCursorObject(BasicDBObject query, FilterItem item) {
private String getOperatorName(FilterItem item) {
final String operatorName;
switch (item.getOperator()) {
- case EQUALS_TO:
+ case EQUALS_TO: case LIKE:
--- End diff --
I agree, will add a linebreak.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29234658
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +441,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
+
+ private String replaceWildCardLikeChars(String operand) {
+ return operand.replace("%","");
--- End diff --
Shouldn't this replace with something like ```.*```? Or else it seems to me it is just removing the % symbol?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29319785
--- Diff: mongodb/src/main/java/org/apache/metamodel/mongodb/MongoDbDataContext.java ---
@@ -435,6 +442,19 @@ private String getOperatorName(FilterItem item) {
return operatorName;
}
+ private Pattern turnOperandIntoRegExp(Object operand) {
+ String operandAsString = operand.toString();
+ StringBuilder operandAsRegExp = new StringBuilder(replaceWildCardLikeChars(operandAsString));
+ if (!operandAsString.startsWith("%") && operandAsString.contains("%")) {
+ operandAsRegExp = operandAsRegExp.insert(0, "^");
+ }
+ return Pattern.compile(operandAsRegExp.toString(), Pattern.CASE_INSENSITIVE);
+ }
--- End diff --
Isn't this missing the ```LIKE '%xxxxxx'``` case? I'd imagine a regex with $ in the end in that case, so that ```xxxxxxy``` wouldn't match, while ```yxxxxxx``` would.
But do we even need all these special cases? I would guess that always adding ^ and $ would always make it work? A few examples:
```LIKE 'xxxxxx'``` would become ```/^xxxxxxx$/``` which would only match ```xxxxxx```.
```LIKE '%xxxxxx'``` would become ```/^.*xxxxxx$/``` which would match anything ending with ```xxxxxx```.
```LIKE 'xxxxxx%'``` would become ```/^xxxxxx.*$/``` which would match anything starting with ```xxxxxx```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97389818
Looks super! Let's merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29324869
--- Diff: mongodb/src/test/java/org/apache/metamodel/mongodb/MongoDbDataContextTest.java ---
@@ -490,4 +490,59 @@ public void run(UpdateCallback callback) {
dc.refreshSchemas();
assertEquals(0, defaultSchema.getTableCount());
}
+
+ public void testSelectWithLikeOperator() throws Exception {
+ if (!isConfigured()) {
+ System.err.println(getInvalidConfigurationMessage());
+ return;
+ }
+
+ DBCollection col = db.createCollection(getCollectionName(), null);
+
+ // delete if already exists
+ {
+ col.drop();
+ col = db.createCollection(getCollectionName(), null);
+ }
+
+ final BasicDBObject dbRow = new BasicDBObject();
+ dbRow.append("name", new BasicDBObject().append("first", "John").append("last", "Doe"));
+ dbRow.append("gender", "MALE");
+ col.insert(dbRow);
+
+ final BasicDBObject dbRow2 = new BasicDBObject();
+ dbRow2.append("name", new BasicDBObject().append("first", "Mary").append("last", "Johnson"));
+ dbRow2.append("gender", "FEMALE");
+ col.insert(dbRow2);
+
+ final BasicDBObject dbRow3 = new BasicDBObject();
+ dbRow3.append("name", new BasicDBObject().append("first", "X").append("last", "Unknown"));
+ dbRow3.append("gender", "UNKNOWN");
+ col.insert(dbRow3);
+
+ final MongoDbDataContext dc = new MongoDbDataContext(db, new SimpleTableDef(getCollectionName(), new String[] {
+ "name.first", "name.last", "gender", "addresses", "addresses[0].city", "addresses[0].country",
+ "addresses[5].foobar" }));
+
+ final DataSet ds1 = dc.executeQuery("select * from my_collection where gender LIKE '%MALE%'");
+ final DataSet ds2 = dc.executeQuery("select * from my_collection where gender LIKE 'MALE%'");
+ final DataSet ds3 = dc.executeQuery("select * from my_collection where gender LIKE '%NK%OW%'");
+ final DataSet ds4 = dc.executeQuery("select * from my_collection where gender LIKE '%MALE'");
+ try {
+ assertTrue(ds1.next());
+ assertTrue(ds1.next());
+ assertFalse(ds1.next());
+ assertTrue(ds2.next());
+ assertFalse(ds2.next());
+ assertTrue(ds3.next());
+ assertFalse(ds3.next());
+ assertTrue(ds4.next());
+ assertTrue(ds4.next());
+ assertFalse(ds4.next());
+ } finally {
+ ds1.close();
+ ds2.close();
+ ds3.close();
+ }
--- End diff --
Pretty minor, but ds4 isn't closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/21#discussion_r29324923
--- Diff: mongodb/src/test/java/org/apache/metamodel/mongodb/MongoDbDataContextTest.java ---
@@ -490,4 +490,59 @@ public void run(UpdateCallback callback) {
dc.refreshSchemas();
assertEquals(0, defaultSchema.getTableCount());
}
+
+ public void testSelectWithLikeOperator() throws Exception {
+ if (!isConfigured()) {
+ System.err.println(getInvalidConfigurationMessage());
+ return;
+ }
+
+ DBCollection col = db.createCollection(getCollectionName(), null);
+
+ // delete if already exists
+ {
+ col.drop();
+ col = db.createCollection(getCollectionName(), null);
+ }
+
+ final BasicDBObject dbRow = new BasicDBObject();
+ dbRow.append("name", new BasicDBObject().append("first", "John").append("last", "Doe"));
+ dbRow.append("gender", "MALE");
+ col.insert(dbRow);
+
+ final BasicDBObject dbRow2 = new BasicDBObject();
+ dbRow2.append("name", new BasicDBObject().append("first", "Mary").append("last", "Johnson"));
+ dbRow2.append("gender", "FEMALE");
+ col.insert(dbRow2);
+
+ final BasicDBObject dbRow3 = new BasicDBObject();
+ dbRow3.append("name", new BasicDBObject().append("first", "X").append("last", "Unknown"));
+ dbRow3.append("gender", "UNKNOWN");
+ col.insert(dbRow3);
+
+ final MongoDbDataContext dc = new MongoDbDataContext(db, new SimpleTableDef(getCollectionName(), new String[] {
+ "name.first", "name.last", "gender", "addresses", "addresses[0].city", "addresses[0].country",
+ "addresses[5].foobar" }));
+
+ final DataSet ds1 = dc.executeQuery("select * from my_collection where gender LIKE '%MALE%'");
+ final DataSet ds2 = dc.executeQuery("select * from my_collection where gender LIKE 'MALE%'");
+ final DataSet ds3 = dc.executeQuery("select * from my_collection where gender LIKE '%NK%OW%'");
+ final DataSet ds4 = dc.executeQuery("select * from my_collection where gender LIKE '%MALE'");
+ try {
+ assertTrue(ds1.next());
+ assertTrue(ds1.next());
+ assertFalse(ds1.next());
+ assertTrue(ds2.next());
+ assertFalse(ds2.next());
+ assertTrue(ds3.next());
+ assertFalse(ds3.next());
+ assertTrue(ds4.next());
+ assertTrue(ds4.next());
+ assertFalse(ds4.next());
+ } finally {
+ ds1.close();
+ ds2.close();
+ ds3.close();
+ }
--- End diff --
Good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Add LIKE operator support. Fixes #METAMODE...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/21#issuecomment-97383057
Minor issue left, but looks good to me! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---