You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/19 17:49:25 UTC

[GitHub] [spark] Swinky commented on a change in pull request #31318: [SPARK-34222][SQL] Enhance boolean simplification rule

Swinky commented on a change in pull request #31318:
URL: https://github.com/apache/spark/pull/31318#discussion_r579365094



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -352,10 +352,7 @@ object BooleanSimplification extends Rule[LogicalPlan] with PredicateHelper {
         val lhs = splitDisjunctivePredicates(left)

Review comment:
       updated the comment, thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org