You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/27 09:58:52 UTC

[GitHub] ashb commented on a change in pull request #3: Add make

ashb commented on a change in pull request #3: Add make
URL: https://github.com/apache/incubator-airflow-ci/pull/3#discussion_r220856381
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -95,7 +96,7 @@ RUN sed -i 's/^# en_US.UTF-8 UTF-8$/en_US.UTF-8 UTF-8/g' /etc/locale.gen \
 # Install Hadoop
 RUN cd /tmp && \
     wget -q https://archive.cloudera.com/cdh5/cdh/5/hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz && \
-    tar xzf hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz --strip-components 1 -C $HADOOP_HOME && \
+    tar xzf hadoop-${HADOOP_VERSION}-cdh5.11.0.tar.gz --absolute-names --strip-components 1 -C $HADOOP_HOME && \
 
 Review comment:
   What's this flag change for?
   
   It sounds someone counter-intuative when combined with -C -- absolute-names means any absolute paths in the tar will be extracted to there, but with strip-components, and -C mean we want to extract into to a specific subdir...?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services