You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/29 13:08:43 UTC
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new issue #18: feat: add apisix call to terminate plugin runner
tzssangglass opened a new issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18
right now apisix just starts the plugin runner, but there is no support for stopping the plugin runner, which means that when apisix is stopped, the plugin runner will still be running. I don't think this makes sense, because the plugin runner lifecycle starts and should end with apisix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-850831044
cc @spacewander @dmsolr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-850940713
so the cmd command should add nohup?
the original cmd I had in mind was
```yaml
ext-plugin:
cmd: nohup java -jar /root/IdeaProjects/apisix-java-plugin-runner-1/dist/apisix-runner-bin/apisix-java-plugin-runner.jar > logs/java_runner.log 2>&1 &
```
now I changed it to this
```yaml
ext-plugin:
cmd: ['java', '-jar', '-Xmx4g', '-Xms4g', '/root/IdeaProjects/apisix-java-plugin-runner-1/dist/apisix-runner-bin/apisix-java-plugin-runner.jar']
```
and there is no need to provide startup.sh for APISIX to execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-850843483
ok, I will try to implement this logic later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-850930020
You don't need to implement it. The runner must be terminated when APISIX stops.
> The sub-process will be killed via SIGKILL if it is still alive when the instance is collected by the garbage collector.
https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/pipe.md#spawn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-850837106
I just try it with the Go Plugin runner and it will be terminated when APISIX stops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
tzssangglass closed issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on issue #18: feat: add apisix call to terminate plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #18:
URL: https://github.com/apache/apisix-java-plugin-runner/issues/18#issuecomment-851098312
Yes, there is no need to add nohup as the command should not be run as a daemon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org