You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/03/26 21:13:51 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2419: Mark test unstable - TestMultiZKConnectionConfig - testZkHelixManager
desaikomal opened a new pull request, #2419:
URL: https://github.com/apache/helix/pull/2419
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #2413
### Description
While debugging TestMultiZKConnectionConfig, realized that we are not able to create the client properly and the reason seems to be previous connection may not have cleaned up ZK data.
Here is the error:
[TestNGInvoker-testZKHelixManager()] ERROR org.apache.helix.manager.zk.ZKHelixManager [] - fail to createClient. retry 1 2023-03-17T12:38:17.0362495Z org.apache.helix.HelixException: Cluster structure is not set up for cluster: CLUSTER_1
2023-03-17T12:38:17.0363854Z at org.apache.helix.manager.zk.ZKHelixManager.handleNewSession(ZKHelixManager.java:1382) ~[classes/:?]
2023-03-17T12:38:17.0364689Z at org.apache.helix.manager.zk.ZKHelixManager.createClient(ZKHelixManager.java:782) [classes/:?]
2023-03-17T12:38:17.0365558Z at org.apache.helix.manager.zk.ZKHelixManager.connect(ZKHelixManager.java:816) [classes/:?]
Till we figure out how to make sure that cluster1 is cleaned up properly, marking the test unstable.
### Tests
- [ ] The following tests are written for this issue:
- The following is the result of the "mvn test" command on the appropriate module:
Testing Done: 5 times tested.
START TestMultiZkConnectionConfig_testCreateParticipants at Sun Mar 26 14:01:10 PDT 2023 END TestMultiZkConnectionConfig_testCreateParticipants at Sun Mar 26 14:01:31 PDT 2023 [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 325.831 s - in org.apache.helix.integration.multizk.TestMultiZkConnectionConfig [INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [INFO]
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on pull request #2419: Mark test unstable - TestMultiZKConnectionConfig - testZkHelixManager
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on PR #2419:
URL: https://github.com/apache/helix/pull/2419#issuecomment-1492786661
Curious, how are we making test unstable in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2419: Mark test unstable - TestMultiZKConnectionConfig - testZkHelixManager
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2419:
URL: https://github.com/apache/helix/pull/2419#issuecomment-1484285335
Please note, TestMultiZKJavaApi - extends TestMultiZKConnectionConfig and calls the 2 disabled testcases as super() method and they pass all the time.
So there is no fundamental issue with the methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal closed pull request #2419: Mark test unstable - TestMultiZKConnectionConfig - testZkHelixManager
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal closed pull request #2419: Mark test unstable - TestMultiZKConnectionConfig - testZkHelixManager
URL: https://github.com/apache/helix/pull/2419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org