You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2009/07/01 05:48:47 UTC
[jira] Created: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
------------------------------------------------------------------------------
Key: HBASE-1596
URL: https://issues.apache.org/jira/browse/HBASE-1596
Project: Hadoop HBase
Issue Type: Bug
Reporter: Nitay Joffe
Assignee: Nitay Joffe
Fix For: 0.20.0
We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1596:
-------------------------------
Attachment: hbase-1596.patch
This patch removes WatcherWrapper, forcing all users of ZooKeeperWrapper to pass in a Watcher at construction time. This is to better force the users of the class to handle things like session expired.
Currently the only user of ZooKeeperWrapper that doesn't pass in a Watcher is the Master. This adds an empty one. There is a separate jira, HBASE-1575, to handle session expired on the master. The rest (RegionServer, TableServers) are already passing in a watcher and handling session expired.
> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
> Key: HBASE-1596
> URL: https://issues.apache.org/jira/browse/HBASE-1596
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727012#action_12727012 ]
Jonathan Gray commented on HBASE-1596:
--------------------------------------
Patch looks fine to me.
When do we need to do something for this?
{noformat}
+ public void process(WatchedEvent event) {
+ // TODO: Write me to handle session expired events.
+ }
{noformat}
> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
> Key: HBASE-1596
> URL: https://issues.apache.org/jira/browse/HBASE-1596
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727013#action_12727013 ]
Jonathan Gray commented on HBASE-1596:
--------------------------------------
Doh. Scratch that. +1 for commit.
> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
> Key: HBASE-1596
> URL: https://issues.apache.org/jira/browse/HBASE-1596
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-1596:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed.
> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
> Key: HBASE-1596
> URL: https://issues.apache.org/jira/browse/HBASE-1596
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1596) Remove WatcherWrapper and have all
users of ZooKeeperWrapper supply a Watcher.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1596:
-------------------------------
Status: Patch Available (was: Open)
> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
> Key: HBASE-1596
> URL: https://issues.apache.org/jira/browse/HBASE-1596
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.