You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by mi...@apache.org on 2009/07/29 00:02:21 UTC

svn commit: r798718 - in /apr/apr/trunk: CHANGES build/rpm/apr.spec.in

Author: minfrin
Date: Tue Jul 28 22:02:21 2009
New Revision: 798718

URL: http://svn.apache.org/viewvc?rev=798718&view=rev
Log:
Make sure that "make check" is used in the RPM spec file, so that
the crypto, dbd and dbm tests pass.

Modified:
    apr/apr/trunk/CHANGES
    apr/apr/trunk/build/rpm/apr.spec.in

Modified: apr/apr/trunk/CHANGES
URL: http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=798718&r1=798717&r2=798718&view=diff
==============================================================================
--- apr/apr/trunk/CHANGES [utf-8] (original)
+++ apr/apr/trunk/CHANGES [utf-8] Tue Jul 28 22:02:21 2009
@@ -1,13 +1,14 @@
                                                      -*- coding: utf-8 -*-
 Changes for APR 2.0.0
 
+  *) Make sure that "make check" is used in the RPM spec file, so that
+     the crypto, dbd and dbm tests pass. [Graham Leggett]
+
   *) Make sure the mysql version of dbd_mysql_get_entry() respects the
      rule that if the column number exceeds the number of columns, we
      return NULL. [Graham Leggett]
 
-  *) Make sure the LD_LIBRARY_PATH is sensible when running the tests
-     from the RPM build, so that the crypto, dbd and dbm tests pass.
-     Transfer the apr-util spec file contents to apr.spec. [Graham
+  *) Transfer the apr-util spec file contents to apr.spec. [Graham
      Leggett]
 
   *) Clarify the error messages within the dbd tests. [Graham Leggett]

Modified: apr/apr/trunk/build/rpm/apr.spec.in
URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/rpm/apr.spec.in?rev=798718&r1=798717&r2=798718&view=diff
==============================================================================
--- apr/apr/trunk/build/rpm/apr.spec.in (original)
+++ apr/apr/trunk/build/rpm/apr.spec.in Tue Jul 28 22:02:21 2009
@@ -138,7 +138,7 @@
 # Run non-interactive tests
 pushd test
 make %{?_smp_mflags} all CFLAGS=-fno-strict-aliasing
-LD_LIBRARY_PATH=../crypto/.libs:../dbd/.libs:../dbm/.libs ./testall -v || exit 1
+make check || exit 1
 popd
 
 %install



Re: svn commit: r798718 - in /apr/apr/trunk: CHANGES build/rpm/apr.spec.in

Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Jul 28, 2009 at 6:02 PM, <mi...@apache.org> wrote:

> Author: minfrin
> Date: Tue Jul 28 22:02:21 2009
> New Revision: 798718
>
> URL: http://svn.apache.org/viewvc?rev=798718&view=rev
> Log:
> Make sure that "make check" is used in the RPM spec file, so that
> the crypto, dbd and dbm tests pass.
>
> Modified:
>    apr/apr/trunk/CHANGES
>    apr/apr/trunk/build/rpm/apr.spec.in
>
> Modified: apr/apr/trunk/CHANGES
> URL:
> http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=798718&r1=798717&r2=798718&view=diff
>
> ==============================================================================
> --- apr/apr/trunk/CHANGES [utf-8] (original)
> +++ apr/apr/trunk/CHANGES [utf-8] Tue Jul 28 22:02:21 2009
> @@ -1,13 +1,14 @@
>                                                      -*- coding: utf-8 -*-
>  Changes for APR 2.0.0
>
> +  *) Make sure that "make check" is used in the RPM spec file, so that
> +     the crypto, dbd and dbm tests pass. [Graham Leggett]
> +
>   *) Make sure the mysql version of dbd_mysql_get_entry() respects the
>      rule that if the column number exceeds the number of columns, we
>      return NULL. [Graham Leggett]
>
> -  *) Make sure the LD_LIBRARY_PATH is sensible when running the tests
> -     from the RPM build, so that the crypto, dbd and dbm tests pass.
> -     Transfer the apr-util spec file contents to apr.spec. [Graham
> +  *) Transfer the apr-util spec file contents to apr.spec. [Graham
>      Leggett]
>

This fix for a bug never present in a release (somebody didn't merge the
apr-util spec file) is not needed in CHANGES.

What should be added is a general note that APR-Util has been merged as of
APR 2.0.